"Edit in settings.json" link invisible when using "Light (Arduino)" theme

[per1234]

Describe the problem

There are two commands that can be used to adjust the IDE's advanced settings:

• "Preferences: Open Settings (UI)"
• "Preferences: Open Settings (JSON)"

The first of these opens a convenient graphical interface which provides direct control over most settings. However, certain settings can only be adjusted by editing the settings.json file directly. These are listed in the GUI-based "Preferences" view, with an "Edit in settings.json" link that opens settings.json with the setting populated and selected when the user clicks the link.

🐛 The color of the "Edit in settings.json" link has extremely low contrast against the background color when the "Light (Arduino)" theme is active, rendering it almost invisible. The users will be unlikely to see the link and so will not have any way to know how to adjust these settings.

To reproduce

1. Select File > Preferences... from the Arduino IDE menus.
2. Select "Light (Arduino)" from the "Theme" menu.
3. Click the OK button.
4. Press the Ctrl+Shift+P keyboard shortcut (Command+Shift+P for macOS users) to open the "Command Palette".
5. Select the "Preferences: Open Settings (UI)" command from the menu.
6. A "Preferences" tab will now open in the Arduino IDE. In the "Search Settings" field of that tab, type editor.rulers
   ⓘ This is one arbitrary example out of the many settings that have this link.

🐛 The "Edit in settings.json" link is nearly invisible:

Expected behavior

The "Edit in settings.json" link has good contrast against the background color when using any of the supported themes.

Arduino IDE version

2.0.1-snapshot-0c20ae0

Operating system

Windows

Operating system version

10

Additional context

The issue does not occur when one of the other two supported themes ("Dark (Arduino)" and "High Contrast (Theia)") are selected.

---

Related

• Un-pulled remote sketch is barely visible with the dark theme #1578
• Improve the selection color in the terminal #1400
• Error line editor decorator not visible when using "High Contrast" themes #1271
• Improve contrast of cursor color in "Dark (Arduino)" theme #1251
• Use a more readable color for "Output" view stderr text in the "Light (Arduino)" theme #1087

Issue checklist

• I searched for previous reports in the issue tracker
• I verified the problem still occurs when using the latest nightly build
• My report contains all necessary details