`network` boards not shown in board selector dropdown

[kittaakos]

Describe the problem

@ubidefeo reported:

won’t show in the board select menu but it shows in the menu and in the “show all ports”

To reproduce

I have neither the exact steps nor a board, but I have the JSON produced by the CLI when attaching/detaching the board.

ino-cli board list -w --format json:

{
  "type": "add",
  "address": "/dev/cu.Bluetooth-Incoming-Port",
  "protocol": "serial",
  "protocol_label": "Serial Port"
}
{
  "type": "add",
  "address": "/dev/cu.usbmodem03",
  "protocol": "serial",
  "protocol_label": "Serial Port (USB)"
}
{
  "type": "add",
  "address": "10.0.1.25",
  "protocol": "network",
  "protocol_label": "Network Port"
}

Detach:

{
  "type": "remove",
  "address": "/dev/cu.usbmodem03",
  "protocol": "serial"
}

{
  "type": "remove",
  "address": "10.0.1.25",
  "protocol": "network",
  "protocol_label": "Network Port"
}

Attach:

{
  "type": "add",
  "address": "/dev/cu.usbmodem03",
  "protocol": "serial",
  "protocol_label": "Serial Port (USB)"
}

{
  "type": "add",
  "address": "10.0.1.25",
  "protocol": "network",
  "protocol_label": "Network Port"
}

Expected behavior

The network board shows up in the board select dropdown.

Arduino IDE version

Version: 2.0.0-rc9.2-nightly-20220816 Date: 2022-08-16T03:34:58.538Z CLI Version: git-snapshot [6e007379] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.3.1

Additional context

Related: arduino/mdns-discovery#25

Issue checklist

• I searched for previous reports in the issue tracker
• I verified the problem still occurs when using the latest nightly build
• My report contains all necessary details

[kittaakos]

IDE2 renders non-serial ports only if the board is recognized by the CLI. I do not know why but here is the change.

[kittaakos]

I do not know why but here is the change.

Same code twice: 74bfdc4#diff-e42c82bb67e277cfa4598239952afd65db44dba55dc7d68df619dfccfa648279R415-R423. It should be cleaned up once we figure out why it is there.

[kittaakos]

Allowing unrecognized ports with network protocol fixes the issue, but I do not know the implication or why unrecognized network ports were disabled in the first place.

[per1234]

why unrecognized network ports were disabled in the first place.

I am not very knowledgeable on the subject of network ports (mostly because I have not been able to use them on Windows due to arduino/mdns-discovery#25), but maybe it was related to this:

#567 (comment)

Recent versions of the mdns-discovery was returning ports that must not have been returned including those not supporting Arduino OTA. i.e. Printers, laptops and similar.