Do not bail out if invalid PID is detected during board listing #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The USB PID, in theory, should be always filled with a value, but for some reason the serial library is not detecting it correctly. This should fix a fatal error on MacOSX, for some devices the returned PID is empty: $ lsusb 2019-10-18 09:47:32.186 system_profiler[34964:3584353] SPUSBDevice: IOCreatePlugInInterfaceForService failed 0xe00002be Bus 020 Device 000: ID 05ac:8600 Apple Inc. Apple T1 Controller Bus 000 Device 001: ID 1d6b:ISPT Linux Foundation USB 3.0 Bus Bus 000 Device 001: ID 1d6b:CIAR Linux Foundation USB 3.1 Bus Bus 001 Device 001: ID 1d6b:CIAR Linux Foundation USB 3.1 Bus This fix should increase robustness until the underlying bug is fixed.
the underlying bug has been fixed in #448, there is no more point in merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The USB PID, in theory, should be always filled with a value, but for some
reason the serial library is not detecting it correctly.
This should fix a fatal error on MacOSX, for some devices the returned
PID is empty:
$ lsusb
2019-10-18 09:47:32.186 system_profiler[34964:3584353] SPUSBDevice: IOCreatePlugInInterfaceForService failed 0xe00002be
Bus 020 Device 000: ID 05ac:8600 Apple Inc. Apple T1 Controller
Bus 000 Device 001: ID 1d6b:ISPT Linux Foundation USB 3.0 Bus
Bus 000 Device 001: ID 1d6b:CIAR Linux Foundation USB 3.1 Bus
Bus 001 Device 001: ID 1d6b:CIAR Linux Foundation USB 3.1 Bus
This fix should increase robustness until the underlying bug is fixed.