Skip to content

Refactoring of the pluggable discovery client #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 28, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

  • Removed useless logic from the pluggable discovery client.
  • Simplified handling of process-termination

What is the current behavior?

No change

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 28, 2023
@cmaglie cmaglie self-assigned this Nov 28, 2023
@cmaglie cmaglie marked this pull request as draft November 29, 2023 14:11
@cmaglie
Copy link
Member Author

cmaglie commented Feb 12, 2024

@cmaglie cmaglie closed this Feb 12, 2024
@cmaglie cmaglie deleted the disc-handler-refactor branch February 12, 2024 13:04
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants