Allow selection of build.core
and build.variant
with variables substitution
#2176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Allows the properties
build.core
andbuild.variant
to have variable substitution placeholders like{variable}
.What is the current behavior?
The
build.core
andbuild.variant
must be constants, otherwise, the build will fail, see #762.This behavior is different from Arduino IDE 1.8.x which instead allows it.
What is the new behavior?
The variable substitution is performed as expected.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #762