[skip-changelog] Run integration tests concurrently #1953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
umbynos
suggested changes
Oct 27, 2022
MatteoPologruto
force-pushed
the
split-integrationtest
branch
2 times, most recently
from
fee0b08 to
b995d75
Compare
|
I made some changes to avoid specifying a different go path. It is no longer needed to build the cli in a specific step of the workflow. |
cmaglie
requested changes
Nov 3, 2022
MatteoPologruto
force-pushed
the
split-integrationtest
branch
2 times, most recently
from
c4d3230 to
e178905
Compare
cmaglie
requested changes
Nov 4, 2022
MatteoPologruto
force-pushed
the
split-integrationtest
branch
from
ca4e645 to
f32d9c4
Compare
This enhancement reduces the amount of time needed to execute integration tests, since each test package no longer has to wait for the previous ones to be completed. In order to do this, a regex is used to match each test file. It is also specified the path to the directory that contains the file.
Having different test files that shared the same package was inefficient, because the whole package test was run one time for each file. This enhancement avoids repeating the same tests more than once.
MatteoPologruto
force-pushed
the
split-integrationtest
branch
from
f32d9c4 to
1cb4633
Compare
cmaglie
approved these changes
Nov 4, 2022
umbynos
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Infrastructure enhancement
What is the current behavior?
Integration tests are run consecutively and each test has to wait for the previous ones to end before starting, making the whole process slower any time a new test is added.
Unit tests and integration tests are executed by different jobs of the workflow.
What is the new behavior?
Using a matrix to run each package test concurrently reduces the waiting time.
GO_TEST_PACKAGEis set to the test package name to identify the single package to run.Does this PR introduce a breaking change, and is titled accordingly?
No