Fix pluggable conversion #1512
Merged
Fix pluggable conversion #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
fix_pluggable_conversion
branch
from
96eddad to
1b9b6bf
Compare
cmaglie
force-pushed
the
fix_pluggable_conversion
branch
from
1b9b6bf to
f444a6e
Compare
silvanocerza
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Fixed an edge case in pluggable discovery compatibility auto-conversion.
Slightly increased test coverage on pluggable monitor compatibility auto-conversion.
in the upload recipes the properties in the form
{upload.network.*}(for example{upload.network.port}) are not converted to their corresponding{upload.port.propeties.*}The PR fixes the above behaviour.
No