Skip to content

Bubble platform download error #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2021
Merged

Bubble platform download error #1217

merged 1 commit into from
Mar 15, 2021

Conversation

ubergesundheit
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    User experience improvement
  • What is the current behavior?
    Trying to install packages with core install <fqdn> is not helpful when downloading of the core file fails
  • What is the new behavior?
    Download errors are displayed to the user

See how to contribute

@ubergesundheit ubergesundheit marked this pull request as ready for review March 9, 2021 22:23
silvanocerza
silvanocerza approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like this. Thanks for the enhancement!

@silvanocerza silvanocerza merged commit b7f3dae into arduino:master Mar 15, 2021
@ubergesundheit ubergesundheit deleted the bubble-platform-download-error branch March 15, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubergesundheit @silvanocerza