Skip to content

[skip changelog] Fix core integration tests #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions test/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,8 @@ def test_core_search_manually_installed_cores_not_printed(run_command, data_dir)
res = run_command("core search --format json")
assert res.ok
cores = json.loads(res.stdout)
assert len(cores) == 17
num_cores = len(cores)
assert num_cores > 0

# Manually installs a core in sketchbooks hardware folder
git_url = "https://github.com/arduino/ArduinoCore-avr.git"
Expand All @@ -381,7 +382,7 @@ def test_core_search_manually_installed_cores_not_printed(run_command, data_dir)
res = run_command("core search --format json")
assert res.ok
cores = json.loads(res.stdout)
assert len(cores) == 17
assert num_cores == len(cores)
mapped = {core["ID"]: core for core in cores}
core_id = "arduino-beta-development:avr"
assert core_id not in mapped
Expand All @@ -394,7 +395,8 @@ def test_core_list_all_manually_installed_core(run_command, data_dir):
res = run_command("core list --all --format json")
assert res.ok
cores = json.loads(res.stdout)
assert len(cores) == 17
num_cores = len(cores)
assert num_cores > 0

# Manually installs a core in sketchbooks hardware folder
git_url = "https://github.com/arduino/ArduinoCore-avr.git"
Expand All @@ -405,7 +407,7 @@ def test_core_list_all_manually_installed_core(run_command, data_dir):
res = run_command("core list --all --format json")
assert res.ok
cores = json.loads(res.stdout)
assert len(cores) == 18
assert num_cores + 1 == len(cores)
mapped = {core["ID"]: core for core in cores}
expected_core_id = "arduino-beta-development:avr"
assert expected_core_id in mapped
Expand All @@ -420,7 +422,8 @@ def test_core_list_updatable_all_flags(run_command, data_dir):
res = run_command("core list --all --updatable --format json")
assert res.ok
cores = json.loads(res.stdout)
assert len(cores) == 17
num_cores = len(cores)
assert num_cores > 0

# Manually installs a core in sketchbooks hardware folder
git_url = "https://github.com/arduino/ArduinoCore-avr.git"
Expand All @@ -431,7 +434,7 @@ def test_core_list_updatable_all_flags(run_command, data_dir):
res = run_command("core list --all --updatable --format json")
assert res.ok
cores = json.loads(res.stdout)
assert len(cores) == 18
assert num_cores + 1 == len(cores)
mapped = {core["ID"]: core for core in cores}
expected_core_id = "arduino-beta-development:avr"
assert expected_core_id in mapped
Expand Down