Migrate TestListWithFqbn from test_lib.py to lib_test.go

Author: MatteoPologruto

internal/integrationtest/lib/lib_test.go

@@ -406,3 +406,45 @@ func TestListExitCode(t *testing.T) {
 	require.NoError(t, err)
 	require.Empty(t, stderr)
 }
+
+func TestListWithFqbn(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Install core
+	_, _, err = cli.Run("core", "install", "arduino:avr")
+	require.NoError(t, err)
+
+	// Look at the plain text output
+	_, _, err = cli.Run("lib", "install", "ArduinoJson")
+	require.NoError(t, err)
+	_, _, err = cli.Run("lib", "install", "wm8978-esp32")
+	require.NoError(t, err)
+
+	// Look at the plain text output
+	stdout, stderr, err := cli.Run("lib", "list", "-b", "arduino:avr:uno")
+	require.NoError(t, err)
+	require.Empty(t, stderr)
+	lines := strings.Split(strings.TrimSpace(string(stdout)), "\n")
+	require.Len(t, lines, 2)
+
+	// Verifies library is compatible
+	lines[1] = strings.Join(strings.Fields(lines[1]), " ")
+	toks := strings.SplitN(lines[1], " ", 5)
+	require.Len(t, toks, 5)
+	require.Equal(t, "ArduinoJson", toks[0])
+
+	// Look at the JSON output
+	stdout, stderr, err = cli.Run("lib", "list", "-b", "arduino:avr:uno", "--format", "json")
+	require.NoError(t, err)
+	require.Empty(t, stderr)
+	requirejson.Len(t, stdout, 1)
+
+	// Verifies library is compatible
+	requirejson.Query(t, stdout, ".[0] | .library | .name", "\"ArduinoJson\"")
+	requirejson.Query(t, stdout, ".[0] | .library | .compatible_with | .\"arduino:avr:uno\"", "true")
+}

test/test_lib.py

@@ -49,41 +49,6 @@ def download_lib(url, download_dir):
     z.close()
 
 
-def test_list_with_fqbn(run_command):
-    # Init the environment explicitly
-    assert run_command(["core", "update-index"])
-
-    # Install core
-    assert run_command(["core", "install", "arduino:avr"])
-
-    # Install some library
-    assert run_command(["lib", "install", "ArduinoJson"])
-    assert run_command(["lib", "install", "wm8978-esp32"])
-
-    # Look at the plain text output
-    result = run_command(["lib", "list", "-b", "arduino:avr:uno"])
-    assert result.ok
-    assert "" == result.stderr
-    lines = result.stdout.strip().splitlines()
-    assert 2 == len(lines)
-
-    # Verifies library is compatible
-    toks = [t.strip() for t in lines[1].split(maxsplit=4)]
-    assert 5 == len(toks)
-    assert "ArduinoJson" == toks[0]
-
-    # Look at the JSON output
-    result = run_command(["lib", "list", "-b", "arduino:avr:uno", "--format", "json"], hide=True)
-    assert result.ok
-    assert "" == result.stderr
-    data = json.loads(result.stdout)
-    assert 1 == len(data)
-
-    # Verifies library is compatible
-    assert data[0]["library"]["name"] == "ArduinoJson"
-    assert data[0]["library"]["compatible_with"]["arduino:avr:uno"]
-
-
 def test_list_provides_includes_fallback(run_command):
     # Verifies "provides_includes" field is returned even if libraries don't declare
     # the "includes" property in their "library.properties" file