Migrate TestListExitCode from test_lib.py to lib_test.go

Author: MatteoPologruto

internal/integrationtest/lib/lib_test.go

@@ -368,3 +368,41 @@ func TestList(t *testing.T) {
 	// be sure data contains the correct provides_includes field
 	requirejson.Query(t, stdout, ".[0] | .library | .provides_includes | .[0]", "\"Arduino_APDS9960.h\"")
 }
+
+func TestListExitCode(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	_, _, err = cli.Run("core", "list")
+	require.NoError(t, err)
+
+	// Verifies lib list doesn't fail when platform is not specified
+	_, stderr, err := cli.Run("lib", "list")
+	require.NoError(t, err)
+	require.Empty(t, stderr)
+
+	// Verify lib list command fails because specified platform is not installed
+	_, stderr, err = cli.Run("lib", "list", "-b", "arduino:samd:mkr1000")
+	require.Error(t, err)
+	require.Contains(t, string(stderr), "Error listing Libraries: Unknown FQBN: platform arduino:samd is not installed")
+
+	_, _, err = cli.Run("lib", "install", "AllThingsTalk LoRaWAN SDK")
+	require.NoError(t, err)
+
+	// Verifies lib list command keeps failing
+	_, stderr, err = cli.Run("lib", "list", "-b", "arduino:samd:mkr1000")
+	require.Error(t, err)
+	require.Contains(t, string(stderr), "Error listing Libraries: Unknown FQBN: platform arduino:samd is not installed")
+
+	_, _, err = cli.Run("core", "install", "arduino:samd")
+	require.NoError(t, err)
+
+	// Verifies lib list command now works since platform has been installed
+	_, stderr, err = cli.Run("lib", "list", "-b", "arduino:samd:mkr1000")
+	require.NoError(t, err)
+	require.Empty(t, stderr)
+}

test/test_lib.py

@@ -49,37 +49,6 @@ def download_lib(url, download_dir):
     z.close()
 
 
-def test_list_exit_code(run_command):
-    # Init the environment explicitly
-    assert run_command(["core", "update-index"])
-
-    assert run_command(["core", "list"])
-
-    # Verifies lib list doesn't fail when platform is not specified
-    result = run_command(["lib", "list"])
-    assert result.ok
-    assert result.stderr.strip() == ""
-
-    # Verify lib list command fails because specified platform is not installed
-    result = run_command(["lib", "list", "-b", "arduino:samd:mkr1000"])
-    assert result.failed
-    assert result.stderr.strip() == "Error listing Libraries: Unknown FQBN: platform arduino:samd is not installed"
-
-    assert run_command(["lib", "install", "AllThingsTalk LoRaWAN SDK"])
-
-    # Verifies lib list command keeps failing
-    result = run_command(["lib", "list", "-b", "arduino:samd:mkr1000"])
-    assert result.failed
-    assert result.stderr.strip() == "Error listing Libraries: Unknown FQBN: platform arduino:samd is not installed"
-
-    assert run_command(["core", "install", "arduino:samd"])
-
-    # Verifies lib list command now works since platform has been installed
-    result = run_command(["lib", "list", "-b", "arduino:samd:mkr1000"])
-    assert result.ok
-    assert result.stderr.strip() == ""
-
-
 def test_list_with_fqbn(run_command):
     # Init the environment explicitly
     assert run_command(["core", "update-index"])