Fix unit tests

Author: silvanocerza

arduino/cores/packagemanager/loader.go

@@ -199,7 +199,7 @@ func (pm *PackageManager) loadPlatform(targetPackage *cores.Package, platformPat
 		platformTxtPath := platformPath.Join("platform.txt")
 		platformProperties, err := properties.SafeLoad(platformTxtPath.String())
 		if err != nil {
-			return status.Newf(codes.FailedPrecondition, "loading platform.txt: %w", err)
+			return status.Newf(codes.FailedPrecondition, "loading platform.txt: %v", err)
 		}
 
 		version := semver.MustParse(platformProperties.Get("version"))

arduino/cores/packagemanager/package_manager_test.go

@@ -228,7 +228,8 @@ func TestFindToolsRequiredForBoard(t *testing.T) {
 	loadIndex("https://dl.espressif.com/dl/package_esp32_index.json")
 	loadIndex("http://arduino.esp8266.com/stable/package_esp8266com_index.json")
 	loadIndex("https://adafruit.github.io/arduino-board-index/package_adafruit_index.json")
-	require.NoError(t, pm.LoadHardware())
+	errs := pm.LoadHardware()
+	require.Len(t, errs, 0)
 	esp32, err := pm.FindBoardWithFQBN("esp32:esp32:esp32")
 	require.NoError(t, err)
 	esptool231 := pm.FindToolDependency(&cores.ToolDependency{

commands/core/search_test.go

@@ -41,8 +41,7 @@ func TestPlatformSearch(t *testing.T) {
 
 	configuration.Settings = configuration.Init(paths.TempDir().Join("test", "arduino-cli.yaml").String())
 
-	inst, err := instance.CreateInstance()
-	require.Nil(t, err)
+	inst := instance.CreateAndInit()
 	require.NotNil(t, inst)
 
 	res, err := PlatformSearch(&rpc.PlatformSearchRequest{

commands/upload/upload_test.go

@@ -127,8 +127,8 @@ func TestDetermineBuildPathAndSketchName(t *testing.T) {
 
 func TestUploadPropertiesComposition(t *testing.T) {
 	pm := packagemanager.NewPackageManager(nil, nil, nil, nil)
-	err := pm.LoadHardwareFromDirectory(paths.New("testdata", "hardware"))
-	require.NoError(t, err)
+	errs := pm.LoadHardwareFromDirectory(paths.New("testdata", "hardware"))
+	require.Len(t, errs, 0)
 	buildPath1 := paths.New("testdata", "build_path_1")
 	logrus.SetLevel(logrus.TraceLevel)
 	type test struct {