Fix instance creation for CLI commands that update indexes

Author: silvanocerza

cli/core/update_index.go

@@ -42,8 +42,16 @@ func initUpdateIndexCommand() *cobra.Command {
 }
 
 func runUpdateIndexCommand(cmd *cobra.Command, args []string) {
-	instance := instance.CreateAndInit()
 	logrus.Info("Executing `arduino core update-index`")
+	// We don't initialize any CoreInstance when updating indexes since we don't need to.
+	// Also meaningless errors might be returned when calling this command with --additional-urls
+	// since the CLI would be searching for a corresponding file for the additional urls set
+	// as argument but none would be obviously found.
+	instance, status := instance.Create()
+	if status != nil {
+		feedback.Errorf("Error creating instance: %v", status)
+		os.Exit(errorcodes.ErrGeneric)
+	}
 
 	_, err := commands.UpdateIndex(context.Background(), &rpc.UpdateIndexRequest{
 		Instance: instance,

cli/lib/update_index.go

@@ -36,7 +36,15 @@ func initUpdateIndexCommand() *cobra.Command {
 		Example: "  " + os.Args[0] + " lib update-index",
 		Args:    cobra.NoArgs,
 		Run: func(cmd *cobra.Command, args []string) {
-			instance := instance.CreateAndInit()
+			// We don't initialize any CoreInstance when updating indexes since we don't need to.
+			// Also meaningless errors might be returned when calling this command with --additional-urls
+			// since the CLI would be searching for a corresponding file for the additional urls set
+			// as argument but none would be obviously found.
+			instance, status := instance.Create()
+			if status != nil {
+				feedback.Errorf("Error creating instance: %v", status)
+				os.Exit(errorcodes.ErrGeneric)
+			}
 			err := commands.UpdateLibrariesIndex(context.Background(), &rpc.UpdateLibrariesIndexRequest{
 				Instance: instance,
 			}, output.ProgressBar())

cli/update/update.go

@@ -49,8 +49,15 @@ var updateFlags struct {
 }
 
 func runUpdateCommand(cmd *cobra.Command, args []string) {
-	instance := instance.CreateAndInit()
-
+	// We don't initialize any CoreInstance when updating indexes since we don't need to.
+	// Also meaningless errors might be returned when calling this command with --additional-urls
+	// since the CLI would be searching for a corresponding file for the additional urls set
+	// as argument but none would be obviously found.
+	instance, status := instance.Create()
+	if status != nil {
+		feedback.Errorf("Error creating instance: %v", status)
+		os.Exit(errorcodes.ErrGeneric)
+	}
 	logrus.Info("Executing `arduino update`")
 
 	err := commands.UpdateCoreLibrariesIndex(context.Background(), &rpc.UpdateCoreLibrariesIndexRequest{