Migrate TestListProvidesIncludesFallback from test_lib.py to lib_test.go

Author: MatteoPologruto

internal/integrationtest/lib/lib_test.go

@@ -448,3 +448,49 @@ func TestListWithFqbn(t *testing.T) {
 	requirejson.Query(t, stdout, ".[0] | .library | .name", "\"ArduinoJson\"")
 	requirejson.Query(t, stdout, ".[0] | .library | .compatible_with | .\"arduino:avr:uno\"", "true")
 }
+
+func TestListProvidesIncludesFallback(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Verifies "provides_includes" field is returned even if libraries don't declare
+	// the "includes" property in their "library.properties" file
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Install core
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+	_, _, err = cli.Run("lib", "install", "ArduinoJson@6.17.2")
+	require.NoError(t, err)
+
+	// List all libraries, even the ones installed with the above core
+	stdout, stderr, err := cli.Run("lib", "list", "--all", "--fqbn", "arduino:avr:uno", "--format", "json")
+	require.NoError(t, err)
+	require.Empty(t, stderr)
+
+	requirejson.Len(t, stdout, 6)
+
+	requirejson.Query(t, stdout, "[.[] | .library | { (.name): .provides_includes }] | add",
+		`{
+			"SPI": [
+		  		"SPI.h"
+			],
+			"SoftwareSerial": [
+		  		"SoftwareSerial.h"
+			],
+			"Wire": [
+		  		"Wire.h"
+			],
+			"ArduinoJson": [
+		  		"ArduinoJson.h",
+		  		"ArduinoJson.hpp"
+			],
+			"EEPROM": [
+		  		"EEPROM.h"
+			],
+			"HID": [
+		  		"HID.h"
+			]
+	  	}`)
+}

test/test_lib.py

@@ -49,32 +49,6 @@ def download_lib(url, download_dir):
     z.close()
 
 
-def test_list_provides_includes_fallback(run_command):
-    # Verifies "provides_includes" field is returned even if libraries don't declare
-    # the "includes" property in their "library.properties" file
-    assert run_command(["update"])
-
-    # Install core
-    assert run_command(["core", "install", "arduino:avr@1.8.3"])
-    assert run_command(["lib", "install", "ArduinoJson@6.17.2"])
-
-    # List all libraries, even the ones installed with the above core
-    result = run_command(["lib", "list", "--all", "--fqbn", "arduino:avr:uno", "--format", "json"], hide=True)
-    assert result.ok
-    assert "" == result.stderr
-
-    data = json.loads(result.stdout)
-    assert 6 == len(data)
-
-    libs = {l["library"]["name"]: l["library"]["provides_includes"] for l in data}
-    assert ["SoftwareSerial.h"] == libs["SoftwareSerial"]
-    assert ["Wire.h"] == libs["Wire"]
-    assert ["EEPROM.h"] == libs["EEPROM"]
-    assert ["HID.h"] == libs["HID"]
-    assert ["SPI.h"] == libs["SPI"]
-    assert ["ArduinoJson.h", "ArduinoJson.hpp"] == libs["ArduinoJson"]
-
-
 def test_lib_download(run_command, downloads_dir):
 
     # Download a specific lib version