Skip to content
This repository was archived by the owner on Apr 1, 2022. It is now read-only.

libraries/compile-examples: support YAML-format sketch-paths input value #74

Merged
merged 1 commit into from
Sep 4, 2020
Merged

libraries/compile-examples: support YAML-format sketch-paths input value #74

merged 1 commit into from
Sep 4, 2020

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Sep 3, 2020

The other two inputs that accept lists: libraries and platforms, support the value being a string in YAML format, following the precedent established by GitHub for their workflows.

For consistency, it makes sense to also support YAML format for the action's sketch-paths input.


Demonstration of how the arduino-libraries/ArduinoIoTCloud repository's workflow would look if it used the new format:
https://github.com/per1234/ArduinoIoTCloud/commit/28af61b7efed26115803c565e173713123c221f5#diff-1ab188640fc440a6dba62ef93d03def2


The old Bash array style space-separated list format is still supported and the default behavior of using the examples folder remain the same, so this change is backwards compatible.

The other two inputs that accept lists: `libraries` and `platforms`, support the value being a string in YAML format, following the precedent established by GitHub for their workflows.

For consistency, it makes sense to also support YAML format for the action's `sketch-paths` input.
@per1234 per1234 added the type: enhancement Proposed improvement label Sep 3, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master       #74     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files            6         2      -4     
  Lines         2486      1372   -1114     
===========================================
- Hits          2486      1372   -1114     
Impacted Files Coverage Δ
...ompile-examples/compilesketches/compilesketches.py 100.00% <100.00%> (ø)
...ples/compilesketches/tests/test_compilesketches.py 100.00% <100.00%> (ø)
...t-size-trends/reportsizetrends/reportsizetrends.py
.../report-size-deltas/tests/test_reportsizedeltas.py
libraries/report-size-deltas/reportsizedeltas.py
...ds/reportsizetrends/tests/test_reportsizetrends.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4f84f...ad41f23. Read the comment docs.

Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you @per1234 🚀

@aentinger aentinger merged commit f49a119 into arduino:master Sep 4, 2020
@per1234 per1234 deleted the sketch-paths-input-yaml-format branch September 4, 2020 05:22
@per1234 per1234 added the topic: code Related to content of the project itself label Sep 29, 2021
@per1234 per1234 self-assigned this Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants