Skip to content

Changing "NONA WLAN" in "Nano 33 IoT" #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2020
Merged

Changing "NONA WLAN" in "Nano 33 IoT" #516

merged 1 commit into from
Dec 10, 2020
+1 −1

Conversation

luigigubello
Copy link
Contributor

Changing "NONA WLAN" in "Nano 33 IoT"

aentinger
aentinger approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, the only line that is actually using the define STRING_PRODUCT is this one. @facchinm I'm wondering if accepting this change would have any undesirable side-effects?

@aentinger aentinger merged commit 1d07ca4 into arduino:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luigigubello @aentinger