HX711 library (Queuetue) no longer talks to device with 1.6.7

[totalgee]

Hello there, I have a program that's talking to a HX711 (using the Queuetue library), and it worked fine with v1.6.6 of the SAMD tools (I'm using MKR1000). Today I updated to v1.6.7, and the same program, same hardware, no longer seems to talk to the HX711, it just always returns zero as the data measurement.

Any tips on what might have changed that could cause this? The HX711 is hooked up with data on A2 and clock on A3, and there is another device using SCL/SDA for I2C (that device is working with both versions of the MKR1000 driver and tools).

If I revert back to 1.6.6, everything works fine again. Thanks for any thoughts on how to solve this.

[sandeepmistry]

Hi @totalgee,

I've tested shiftIn, digitalWrite and digitalRead with 1.6.7, things seem ok to me. I don't have a HX711 to test with unfortunately.

There have been some changes to pinMode and digitalWrite in #101, which disable the pullup in output mode. Not sure if that is the root cause of you issues.

Could you try replacing cores/arduino/wiring_digital.c with the version from 1.6.6? To see if that was the relevant change. Also, does the same thing happen if you change pins?

[totalgee]

Hi, so I tried replacing the wiring_digital.c with the old version from 1.6.6, and it doesn't seem to fix the problem when I rebuild and upload my MKR1000 project.

Just to confirm, do I need to do anything special to build it? I found the file in ~/Library/Arduino15/packages/arduino/hardware/samd/1.6.7/cores/arduino (I'm on OS X) and replaced it with the older file. When I build my project, how do I confirm it's actually compiled and using the modified file? Are there any other steps to perform to test this properly? Thanks.

[totalgee]

If it helps, the hx711.readyToSend() function never returns true any more. The code in the library for this function is:

bool Q2HX711::readyToSend() {
  return digitalRead(OUT_PIN) == LOW;
}

(the confusingly-named OUT_PIN is the data pin (in my case, A2), actually an input to the Arduino (output from the HX711 chip))

Maybe that gives you a hint of what might have changed? Some default relating to digital pins?

[sandeepmistry]

Hi @totalgee,

Just to confirm, do I need to do anything special to build it? I found the file in ~/Library/Arduino15/packages/arduino/hardware/samd/1.6.7/cores/arduino (I'm on OS X) and replaced it with the older file.

That's all you need to do, you can add a #error statement to the file and make sure the build fails to see if it is the right file.

Ok, so it doesn't sound like #101 is the root cause them. A few things to try out:

• The Button.ino example using A2 as the button pin.
• Try using some other pins as data and clock instead of A2 and A3

[totalgee]

Okay, I tried those:

• The Button.ino example works fine for me with 1.6.7, using A2 as the button pin.
• Using (for example) A4 and A5 rather than A2 and A3 doesn't work. (both cases work fine with 1.6.6).

Let me know if there's anything else I can do to help track this down.

[totalgee]

Hi Sandeep, I tried again, this time with v1.6.6, and only putting in the changes to wiring_digital.c from #101 . So, it does seem related to this after all. I tried using other pins, and the same result...it seems to work well (with whichever pins) when using wiring_digital.c from 1.6.6, and not with the one from 1.6.7. Is there something I can do in my own code to enable the pullup in output mode, when using 1.6.7 (if you think that's related to the problem)? Thanks.

[totalgee]

More info: in digitalWrite(), using the 1.6.7 version:

If I add one of the following lines (I suppose they're equivalent) at the end of the function -- i.e. always enabling the pull-up resistor -- then it seems to work fine.

    // Enable pull-up resistor (do one of the following two)
    PORT->Group[port].PINCFG[pin].reg=(uint8_t)(PORT_PINCFG_PULLEN) ;
    PORT->Group[port].PINCFG[pin].bit.PULLEN = 1;

I don't know why it works, but it seems to.

Does this mean the solution is for me to add a hardware pull-up (resistor to Vcc) on that output pin? Or is there a way I can use the existing 1.6.7 code, but force the pull-up in software?

Thanks,
Glen.

[cmaglie]

Does this mean the solution is for me to add a hardware pull-up (resistor to Vcc) on that output pin? Or is there a way I can use the existing 1.6.7 code, but force the pull-up in software?

to enable pull-up you can configure the pin as INPUT_PULLUP:

pinMode(pin, INPUT_PULLUP);

another way that is allowed in the API is to do a digitalWrite(pin, HIGH) while the pin is configured as INPUT:

pinMode(pin, INPUT);
digitalWrite(pin, HIGH); // Enable pull-up but keeps the pin as INPUT

[totalgee]

Thanks, yes, but this is an output pin, it would need something like OUTPUT_PULLUP (which doesn't exist), wouldn't it? I tried setting it as INPUT_PULLUP anyhow, but this doesn't seem to work. Do I have to call pinMode() again after each digitalWrite()?

[cmaglie]

it would need something like OUTPUT_PULLUP

not sure what you mean here, maybe you want something similar to an open-drain output but with pull-up (so OUTPUT LOW for "0", and INPUT PULLUP for "1")?

I also see that "OUT_PIN" is set as a plain INPUT:

https://github.com/queuetue/Q2-HX711-Arduino-Library/blob/master/src/Q2HX711.cpp#L9

so I don't understand why you need it as OUTPUT (or even open-drain).

Can you please also send a complete sketch that reproduces the problem?
This will help to understand your setup.

[totalgee]

It's CLOCK_PIN that's the output (from Arduino) and that's causing problems.

I've attached a sketch that shows the problem (it's essentially just the simple_scale example included with the Queuetue HX711 Library). The minimal requirements are an MKR1000 and a HX711 (I have the "green one", not the red one from Sparkfun); you don't need a load cell connected to the HX711 to repro the problem.

Hx711_SAMD_bug169.txt <-- rename to be .ino extension

[cmaglie]

Aaah ok, now I see, thanks for the clarification.

I'm wondering if pinMode(INPUT_PULLUP) is working as expected. May you try to replace:

pinMode(pin, INPUT_PULLUP);

with:

pinMode(pin, INPUT);
digitalWrite(pin, HIGH); // Enable pull-up but keeps the pin as INPUT

?

[totalgee]

Again...do you mean OUTPUT? The line that seems to be causing trouble is the output (clock). Are you suggesting that I change (in Q2HX711.cpp) the OUTPUT to be an INPUT, then call digitalWrite() to set it HIGH (to enable pull-up)? I've tried various combinations like this (setting the clock output to be INPUT_PULLUP or INPUT followed by set HIGH), with no luck so far.

[cmaglie]

Again...do you mean OUTPUT?

No I really mean INPUT -> INPUT_PULLUP:

Q2HX711::Q2HX711(byte output_pin, byte clock_pin) {
  CLOCK_PIN  = clock_pin;
  OUT_PIN  = output_pin;
  GAIN = 1;
  pinMode(CLOCK_PIN, OUTPUT);
  pinMode(OUT_PIN, INPUT_PULLUP); // <----- add PULLUP here
}

[totalgee]

Nope, I tried but this does not help the problem. As I mentioned, it's the CLOCK_PIN (OUTPUT) that seems to need to be pulled up, not the OUT_PIN (INPUT).