Fix RX_LED #define for R4 Minima #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX_LED is connected to Port0-13 on the Minima
|
|
facchinm
requested changes
Jul 3, 2023
There was a problem hiding this comment.
The right place to add this modification is https://github.com/arduino/ArduinoCore-renesas/blob/main/variants/MINIMA/pins_arduino.h#L73-L76 since this file is autogenerated and can't be used directly.
|
Merged as #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RX_LED is connected to Port0-13 on the Minima
R4 WiFi probably also needs a fix (the defines for RX_LED/TX_LED are the same)
But I did not dig on how the firmware handles RX/TX with the ESP32
See : https://github.com/arduino/ArduinoCore-renesas/blob/main/variants/UNOWIFIR4/includes/ra_cfg/fsp_cfg/bsp/bsp_pin_cfg.h