This repository was archived by the owner on Apr 16, 2021. It is now read-only.
Restructure core bindings #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to adapt the C scoped core functions to the dual usage (standalone and as mbed library) ended up with suboptimal results; this commit tries to make everything more clear, without any side effect. Fixes #30
|
Hey @facchinm, I just applied the changes and everything works fine for me. Would be nice if this can pushed to the master branch! Thanks and kind regards |
This was referenced Mar 18, 2020
polldo
pushed a commit
to polldo/ArduinoCore-nRF528x-mbedos
that referenced
this pull request
Apr 21, 2020
More clever port of arduino#31
polldo
pushed a commit
to polldo/ArduinoCore-nRF528x-mbedos
that referenced
this pull request
Apr 22, 2020
More clever port of arduino#31
|
Included in #81 in a much better way |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to adapt the C scoped core functions to the dual usage (standalone and as mbed library) ended up with suboptimal results; this commit tries to make everything more clear, without any side effect.
Fixes #30
@dcuartielles