-
-
Notifications
You must be signed in to change notification settings - Fork 214
Use build path containing spaces for sketch compilation "smoke tests" #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a custom build path containing spaces for the sketch compilations done by the "Compile Examples" GitHub Actions workflow will catch insufficient path quoting in the compilation patterns defined by the platform.
Memory usage change @ 25e2e34
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a custom build path containing spaces for the sketch compilations done by the "Compile Examples" GitHub Actions
workflow will catch insufficient path quoting in the compilation patterns defined by the platform.
You can see a demonstration of how it would have caught #363 here where I have backported the workflow configuration change to the 2.6.1 tag where the project had insufficient path quoting:
https://github.com/per1234/ArduinoCore-mbed/runs/5686506549?check_suite_focus=true#step:5:83