RP2040: avoid implicit conversion from NinaPin to int #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 569ccb5
Click for full report table
Click for full report CSV |
|
Memory usage change @ e87ade8
Click for full report table
Click for full report CSV |
|
The CI correctly spotted that https://github.com/arduino/ArduinoCore-mbed/blob/master/libraries/Scheduler/examples/MultipleBlinks/MultipleBlinks.ino#L28-L30 cannot work on the Nano RP2040 . What about adding a guard? Or changing the declarations into defines. |
aentinger
reviewed
May 21, 2021
| @@ -93,7 +93,8 @@ jobs: | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| fqbn: ${{ matrix.board.fqbn }} | |||
| libraries: | | |||
| - name: WiFiNINA | |||
| - source-url: https://github.com/facchinm/WiFiNINA.git | |||
There was a problem hiding this comment.
This needs to get out after arduino-libraries/WiFiNINA#180 has been merged and the library released.
There was a problem hiding this comment.
I'll just cherry pick the first commit / force push it on this branch
Some sketches use a pattern like ``` int potpin = A5 ``` Since NinaPin was an enum, the implicit cast was taking place, and any subsequent call to analogRead() would not use the Nina functions. Works in conjunction with arduino-libraries/WiFiNINA#180
facchinm
force-pushed
the
nina_pins_as_class
branch
from
e87ade8 to
dcde080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sketches use a pattern like
Since NinaPin was an enum, the implicit cast was taking place, and any subsequent call to analogRead() would not use the Nina functions.
Works in conjunction with arduino-libraries/WiFiNINA#180