-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add FPSTR() macro to WString.h #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
njh
wants to merge
1
commit into
arduino:master
Choose a base branch
from
njh:add-FPSTR-macro
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 00512ff
Click for full report table
Click for full report CSV
|
Can the spell check fail be ignored? ./libraries/SoftwareSerial/src/SoftwareSerial.cpp:48 "Statics" could be replaced by "Static Definitions"? |
Memory usage change @ 2a257c8
Click for full report table
Click for full report CSV
|
👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds the
FPSTR()
macro to WString.h.The purpose of this Macro is to allow you to pass a previously defined string with the PROGMEM attribute - without having to define it inline (as you do with the
F()
macro).The
F()
macro is also redefined, to make use of theFPSTR()
macro.The macro implementation was taken from WString.h in the esp8266 Arduino core - which is also GPL licensed.
The esp8266 PROGMEM documentation states:
My interest in this Macro is for the EtherCard library to assist with putting the MAC address in programme memory, instead of RAM. I did some tests in this Sketch:
https://gist.github.com/njh/de1cec7c883bcfe35df3956340fa30ab