Skip to content

Append simple multithreading support #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Append simple multithreading support #12

wants to merge 10 commits into from

Conversation

slavaza
Copy link

@slavaza slavaza commented Apr 13, 2018

This small improvement will allow the use of multitasking programming techniques on the smallest Arduino models. It implements iterative multitasking with execution time quantization.

slavaza added 2 commits April 13, 2018 17:03
This fix will allow use HardwareSerial driver in simple multithreading applications.
This simplest library implement iterative multithreading functionality. Allow create and switch the quasi-parallel tasks by yield() function call or 1 ms quantum of time elapsed.
@per1234
Copy link
Contributor

per1234 commented Apr 13, 2018

From the comment on the previous PR (arduino/Arduino#7459 (comment)). It sounds like there is possible interest in your commit to add the yield() call to HardwareSerial::write() (bf53c99) but not in your other commit that adds a Yield library to the core.

By bundling the two only loosely related commits together in a single pull request you make it less likely that the first will be merged. It seems like the best approach for the second is to simply publish the library in a repository of your own and then Arduino users can install it if they like. You can make it even easier to install and more visible by requesting its addition to the Arduino Library Manager index.

@slavaza
Copy link
Author

slavaza commented Apr 13, 2018

@per1234 You have the right to do what you want as developers. I just offered my solution, wanting to play with Arduino. Yes I will try to publish this library separately. I do not search popularity. I just want improve your project that I liked.

slavaza added 3 commits April 13, 2018 18:12
Remove strange unexpected error of edit stage.
Removing incorrect words in comments
Fix incorrect URL of this library
facchinm added a commit that referenced this pull request Oct 19, 2018
Changed approach to F_CPU to be user-defined
slavaza added 4 commits March 15, 2020 15:45
This is a well-tested algorithm in other applications. For the Arduino not tested yet. With the love of art.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants