Skip to content

Klocwork issues #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 5, 2015
Merged

Klocwork issues #62

merged 15 commits into from
Nov 5, 2015

Conversation

kevin306
Copy link

All relevant Klocwork fixes.

Bogdan Pricop and others added 10 commits October 29, 2015 14:53
Fix Klocwork#137: Non-void function does not return value
b3afd60 
Move getTimeStampClks() function to an *.S file
It is fully implemented in assembly and we take care of returning value by
filling in the proper value in the proper registers.

Signed-off-by: Bogdan Pricop <bogdan.pricop@emutex.com>
Fix Klocwork#1093: Infinite loop.
62395e4 
* Added comment to verify requirement for infinite loop.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#91: Infinite loop
db2995a 
* Added comment to verify requirement for infinite loop.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#100: Infinite loop.
5e71e70 
* Added comment to verify requirement for infinite loop.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#105: Pointer returned may be null.
cfe0a5d 
* Added a check for this null pointer.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#671: Infinite loop.
79008fa 
* Added comment to verify requirement for infinite loop.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#79,80,81,82: Uninitialized Variable.
79744c4 
* using memset to initialize struct to zero.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#2081,2082: Uninitialized variable.
dd4845e 
* using memset to initialize struct to zero.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#543,544: Buffer overflow/null pointer
739c400 
* Added a check to ensure array does not access index value of -1.

* Added a check for this null pointer.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Fix Klocwork#2051,2060: Array may be outside index
2ae262a 
* Added check to ensure _data_len is within index values.

* Had to repeat the branch statement rather than move it because of memcpy.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
@pricopb
Copy link

pricopb commented Oct 29, 2015

@calvinatintel, @bbaltz505 please hold off the merge.
I've just run some tests ans it looks like I introduced some new issues while fixing Klocwork#137.
Please let me do a bit more digging and I'll come back with a resolution.

@bbaltz505
Copy link
Contributor

Ok. Thanks Bogdan.

Fix Klocwork#137: Non-void function does not return value
cacac37 
Change getTimeStampClks() implementation from assembly to C.

Signed-off-by: Bogdan Pricop <bogdan.pricop@emutex.com>
@kevin306
Copy link
Author

@bbaltz505 @calvinatintel I have updated pull request with Bogdans fix for Klocwork#137.

@pricopb
Copy link

pricopb commented Oct 30, 2015

Calvin, Brian, I would say we are good to review the changes before merge.
Thanks very much!

@bbaltz505
Copy link
Contributor

Thanks Bogdan and Dan. @kmsywula can you review these KW fixes?

@bbaltz505
Copy link
Contributor

@SidLeung @bigdinotech please review. These are minor fixes for Klocwork defects. Klocwork scans showed possible memory leaks and other issues.

@bigdinotech
Copy link
Contributor

@calvinatintel code looks good tom me +1

Fix Klocwork#2051,2060: Array may be outside index
344f90d 
* Added check to ensure _data_len is within index values.

* Had to repeat the branch statement rather than move it because of memcpy.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
@calvinatintel
Copy link
Contributor

@kmsywula @SidLeung Please review

@bbaltz505
Copy link
Contributor

There are 2 KW defects still in this PR so @pricopb will probably push another update.

Kevin Moloney added 3 commits November 5, 2015 12:33
Fix Klocwork#2051,2060: Array may be outside index
afcc4ef 
* Added check to ensure _data_len is within index values.

* Had to repeat the branch statement rather than move it because of memcpy.

* Fixed bug introduced(c8ecd5f) in WString.h when "len" became protected.

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
Merge branch 'testing' of github.com:kevin306/corelibs-arduino101 int…
5baa3fc 
…o testing

Conflicts:
	libraries/CurieBle/src/BleCharacteristic.cpp
Fix Klocwork#2051,2060: Array may be outside index
3759bcd 
Change && to ||

Signed-off-by: Kevin Moloney <kevin.moloney@emutex.com>
@pricopb
Copy link

pricopb commented Nov 5, 2015

I think we are good now @bbaltz505!
Could you, please, review and merge?
Thank you abd sorry for the delay. :-(

@calvinatintel
Copy link
Contributor

@SidLeung @kmsywula @bigdinotech Please review again!

@bbaltz505
Copy link
Contributor

Klocwork likes your latest changes. :-) +1 from me.

@calvinatintel
Copy link
Contributor

@bbaltz505 Since this issue was for resolving Klocwork messages, I think it should be merged in. Thoughts?

@bbaltz505
Copy link
Contributor

I agree

calvinatintel added a commit that referenced this pull request Nov 5, 2015
@calvinatintel
Merge pull request #62 from kevin306/testing
b30a275 
Klocwork issues
@calvinatintel calvinatintel merged commit b30a275 into arduino:master Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevin306 @pricopb @bbaltz505 @bigdinotech @calvinatintel