Skip to content

Improve accessibility in the Preferences dialog #6913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Improve accessibility in the Preferences dialog #6913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion app/src/cc/arduino/view/preferences/Preferences.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ private void initComponents() {
jTabbedPane1.setRequestFocusEnabled(false);

sketchbookLocationLabel.setText(tr("Sketchbook location:"));

sketchbookLocationLabel.setLabelFor(sketchbookLocationField);

sketchbookLocationField.setColumns(40);

browseButton.setText(I18n.PROMPT_BROWSE);
Expand All @@ -187,21 +188,28 @@ public void actionPerformed(java.awt.event.ActionEvent evt) {
comboLanguageLabel.setText(tr("Editor language: "));

requiresRestartLabel.setText(tr(" (requires restart of Arduino)"));

comboLanguage.getAccessibleContext().setAccessibleName("Editor language (requires restart of Arduino)");

fontSizeLabel.setText(tr("Editor font size: "));
fontSizeLabel.setLabelFor(fontSizeField);

fontSizeField.setColumns(4);

showVerboseLabel.setText(tr("Show verbose output during: "));

verboseCompilationBox.setText(tr("compilation "));
verboseCompilationBox.getAccessibleContext().setAccessibleName("Show verbose output during compilation");

verboseUploadBox.setText(tr("upload"));
verboseUploadBox.getAccessibleContext().setAccessibleName("Show verbose output during upload");

comboWarningsLabel.setText(tr("Compiler warnings: "));
comboWarningsLabel.setLabelFor(comboWarnings);

additionalBoardsManagerLabel.setText(tr("Additional Boards Manager URLs: "));
additionalBoardsManagerLabel.setToolTipText(tr("Enter a comma separated list of urls"));
additionalBoardsManagerLabel.setLabelFor(additionalBoardsManagerField);

additionalBoardsManagerField.setToolTipText(tr("Enter a comma separated list of urls"));

Expand All @@ -212,6 +220,7 @@ public void actionPerformed(java.awt.event.ActionEvent evt) {
extendedAdditionalUrlFieldWindowActionPerformed(evt);
}
});
extendedAdditionalUrlFieldWindow.getAccessibleContext().setAccessibleName("New Window");

morePreferencesLabel.setForeground(Color.GRAY);
morePreferencesLabel.setText(tr("More preferences can be edited directly in the file"));
Expand All @@ -229,6 +238,7 @@ public void mouseEntered(java.awt.event.MouseEvent evt) {
preferencesFileLabelMouseEntered(evt);
}
});
preferencesFileLabel.setFocusable(true);

arduinoNotRunningLabel.setForeground(Color.GRAY);
arduinoNotRunningLabel.setText(tr("(edit only when Arduino is not running)"));
Expand Down Expand Up @@ -280,6 +290,7 @@ public void mouseEntered(java.awt.event.MouseEvent evt) {

scaleSpinner.setModel(new javax.swing.SpinnerNumberModel(100, 100, 400, 5));
scaleSpinner.setEnabled(false);
scaleSpinner.getAccessibleContext().setAccessibleName("Interface scale (requires restart of Arduino)");

autoScaleCheckBox.setSelected(true);
autoScaleCheckBox.setText(tr("Automatic"));
Expand All @@ -288,6 +299,7 @@ public void itemStateChanged(java.awt.event.ItemEvent evt) {
autoScaleCheckBoxItemStateChanged(evt);
}
});
autoScaleCheckBox.getAccessibleContext().setAccessibleName("Automatic interface scale (requires restart of Arduino");

jLabel3.setText("%");

Expand Down