Skip to content

Add FreeBSD Platform Tag -- supports x86_64-freebsd, arm*-freebsd, an… #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2017

Conversation

kevans91
Copy link

@kevans91 kevans91 commented Oct 4, 2016

…d i386-freebsd with optional extension for tagging a specific release (e.g. freebsd11) if it's decided to do so later.

This should give us the widest range of flexibility/compatibility, I believe.

Kyle Evans added 2 commits October 3, 2016 23:37
…d i386-freebsd with optional extension for tagging specific release (e.g. freebsd11)
@kevans91
Copy link
Author

Hi, ping @cmaglie, @facchinm =)

This seems like a fairly straightforward addition that shouldn't affect anyone else -- it would be nice if it could become a candidate for inclusion in 1.8.1 if you have time.

The arch matching doesn't get as in-depth as the other platforms because there's not really any need. Packages are not supplied by Arduino, so we build them ourselves on demand.

Because of this, we roll a custom version of the package_index_bundled.json that suits the machine that it's currently building on or for. Checksums and sizes go away, and we keep one "systems" entry that generally sets "host" to "$(uname -m)-freebsd$(major_version)" -- it's worth noting that the major version isn't actually worth anything here, because the package being built already reflects the FreeBSD version. I've included it, though, in case people try to do funky things.

Your consideration is appreciated, =)

@facchinm
Copy link
Member

facchinm commented Jan 2, 2017

LGTM 👍

@kevans91
Copy link
Author

kevans91 commented Jan 2, 2017

=)

Some additional thoughts: would you guys consider a PR adding some mechanism that allows either the packager or you to declare a platform as 'unsupported', bypassing these platform checks?

I ask because right now, I have to heavily patch the package_index_bundled.json to effectively do the above. This isn't necessarily a good solution -- I know my platform is unsupported, and I know that I have to put the work in to making sure that the dependencies are all there and proper.

Adding this host tag is still nice, though, because eventually I might be in a position where I can provide the dependencies bundled as you do and would rather do it through the official channels as far as I can as a third party.

@facchinm facchinm merged commit 44c0c73 into arduino:master Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants