Skip to content

Buildfixes: Better linux packaging and https #5438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Buildfixes: Better linux packaging and https #5438

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5de6c1f
Add option to disable doc packaging
NicoHood Oct 3, 2016
b637e38
Fix light_bundle package option
NicoHood Oct 3, 2016
4cee989
Added option local_sources for better linux packaging with predownloa…
NicoHood Oct 3, 2016
f224a39
Use https in build downloads
NicoHood Oct 3, 2016
58b8b3f
Merge remote-tracking branch 'upstream/master' into buildfix
NicoHood Nov 26, 2016
11e8091
Merge remote-tracking branch 'upstream/master' into buildfix
NicoHood Dec 23, 2016
f29abf8
Added build option for disabling arduino-builder
NicoHood Dec 23, 2016
4f41384
Added platform.txt files back to hardware folder. Fixes arduino-builder
NicoHood Dec 23, 2016
054bc50
Merge remote-tracking branch 'upstream/master' into buildfix
NicoHood Dec 27, 2016
35e5f33
Revert "Added platform.txt files back to hardware folder. Fixes ardui…
NicoHood Dec 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions build/build.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,8 +834,21 @@

<!-- Retrieve tool -->
<target name="untar-unzip-download" depends="untar-unzip-check" unless="${archive_file}_available">
<antcall target="untar-unzip-download-web" />
<antcall target="untar-unzip-download-local" />
</target>
<target name="untar-unzip-download-web" unless="local_sources">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this distinction really needed?

AFAIR if you copy the needed archives in the right place before launching the build, the file is not downloaded again (this is done in the untar-unzip-check that is a dependency of untar-unzip-download).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the biggest reasons I remember is that some paths are different for different architectures or not existant (mkdir -p). On top of that you need to always change the PKGBUILD and need to carefully check where the build script wants to have its downloaded files. This makes it harder to maintain.

This patch makes it simpler to search the download files from a local source instead.

<get src="${archive_url}" dest="${archive_file}" verbose="true" ignoreerrors="true" />
</target>
<target name="untar-unzip-download-local" if="local_sources">
<basename file="${archive_file}" property="basename" />
<echo>Skipping download of ${archive_url}, using makepkg downloaded ${basename}</echo>
<exec executable="ln" failonerror="true">
<arg value="-s" />
<arg value="${basedir}/../../${basename}" />
<arg value="${archive_file}" />
</exec>
</target>

<target name="untar-unzip-checksum" depends="untar-unzip-download">
<echo>Testing checksum of "${archive_file}"</echo>
Expand Down