Fix for FileUtils.recursiveDelete() when dealing with symbolic links #3141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for File.delete() says that the method return true
if the the file is successfully deleted, otherwise false is returned.
An exception is thrown only when the file is not accessible (for
permission problem).
Removing the extra check solves another problem, for example in a
folder with the following situation:
linkToFileA -> FileA
FileA
if we remove FileA, we remain with a broken link that can't be removed
using FileUtils.deleteIfExists() because calling File.exists() on a
broken link returns *false*. This commit solve this problem.
file is already checked for being not null, no need to check again.
| @@ -85,7 +85,7 @@ public static void recursiveDelete(File file) { | |||
| recursiveDelete(current); | |||
| } | |||
| } | |||
| deleteIfExists(file); | |||
| file.delete(); | |||
There was a problem hiding this comment.
Since you deleted the .exists() check in deleteIfExists, could you still call that function instead of file.delete()? It uses a defensive approach checking if File is null
There was a problem hiding this comment.
It's explained in the second commit: file is already checked for being not null, no need to check again
the check is here: https://github.com/arduino/Arduino/pull/3141/files#diff-fb3046d74e0c4a32b94edd584638ecd3L76
BTW if you prefer to keep the defensive approach and check anyway, just drop the second commit and keep only the first one!
ffissore
added a commit
that referenced
this pull request
May 15, 2015
Fix for FileUtils.recursiveDelete() when dealing with symbolic links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed info in the commit message:
note that the bug not always happens, it depends on the order the files are deleted.