Skip to content

Library debug #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2015
Merged

Library debug #2948

merged 2 commits into from
Apr 9, 2015

Conversation

Lauszus
Copy link
Contributor

@Lauszus Lauszus commented Apr 9, 2015

Print library name when installing via library manager and don't throw exception if library is already installed.

@Lauszus
Copy link
Contributor Author

Lauszus commented Apr 9, 2015

This especially makes sense when multiple libraries are installed at once: #2947.

ffissore added a commit that referenced this pull request Apr 9, 2015
@ffissore ffissore merged commit 8187649 into arduino:master Apr 9, 2015
@ffissore
Copy link
Contributor

ffissore commented Apr 9, 2015

Thanks! I'll change error messages a bit so that they play more nicely with i18n

@Lauszus
Copy link
Contributor Author

Lauszus commented Apr 9, 2015

Okay thanks. I was wondering about that as well, but just submitted it anyway ;)

@Lauszus Lauszus deleted the LibraryDebug branch April 9, 2015 13:25
@ffissore
Copy link
Contributor

ffissore commented Apr 9, 2015

Thank you :) This is the commit f0cc644 . It plays nicer because only string "Library is already installed: \"{0}\"" is extracted and translated. This also allows translations to move {0} around, to fit a particular grammar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants