Fix auto-reset on Leonardo-derived boards from Linux hosts #2709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed the touchPort() function, as it's now unambiguously
single-purpose.
The 1200bps reset from Linux hosts wasn't working with these newer
JSSC-based versions. Adding a step which explicitly sets DTR low (via a
TIOCMSET ioctl clearing DTR) fixes this.
I'm fairly sure the reason why this worked on older Arduino with librxtx
and not with jssc is that librxtx appears to keep HUPCL in the termio
flags, but jssc appears to remove it. If HUPCL ("hangup on close") is
set, it causes DTR to be explicitly pulled low on close.
|
@ArduinoBot build this please |
|
Hi @projectgus, very neat patch and complete explanation, thank you! |
facchinm
added a commit
that referenced
this pull request
Mar 16, 2015
Fix auto-reset on Leonardo-derived boards from Linux hosts
facchinm
added a commit
to arduino/arduino-create-agent
that referenced
this pull request
Sep 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed auto-reset for catarina/atmega32u4 baords wasn't working in 1.6.0 on my Linux computer, and traced it back to the change from librxtx to JSSC.
Technical details in the commit message. I haven't tested this on other platforms, I expect it would probably not break anything but I guess you can never really tell. :)
Hoping I'm not too late to miss the boat for 1.6.1.