Made swap a function to prevent awful error messages from macros. #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e preprocessor macro.
matthijskooijman
added
Library: Other
cmaglie
added
Component: Core
facchinm
added
Board: Arduino Robot
|
@cmaglie should we apply this to Robot_control and TFT repos even if they are in maintenance mode? |
|
I'd say yes. |
|
👍 |
facchinm
added a commit
to arduino-libraries/TFT
that referenced
this pull request
Sep 17, 2019
Partial port of arduino/Arduino#2434
facchinm
added a commit
to arduino-libraries/Robot_Control
that referenced
this pull request
Sep 17, 2019
Partial port of arduino/Arduino#2434
|
Applied to the given repos, closing here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro causes a lot of grief for poor students who aren't yet familiar with gcc's dreadful error messages. Unfortunately "swap" is a common name for functions, and if people aren't careful and declare their own functions when including Adafruit_GFX.h you get a misleading error, as opposed to a duplicate declaration one.