Skip to content

Adds support for Danish language #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 10, 2022
Merged

Adds support for Danish language #60

merged 9 commits into from
Jan 10, 2022

Conversation

PJ789
Copy link
Contributor

@PJ789 PJ789 commented Dec 26, 2021

@facchinm please could you merge into Keyboard?

(.This pull requests supersedes previous pull request)

PJ789 added 2 commits December 10, 2021 15:29
@PJ789
Adds support for Danish language
3589bba 
KeyboardLayout_da_DK.cpp is Danish keyboard layout
Keyboard.h references da_DK.cpp
Keyboard_da_DK.h defines scan codes for Danish characters such as ÆØ.
@PJ789
Changes scan code for blash
124a0cb 
Changed scan code for bslash as suggested by @edgar-bonnet
@PJ789
Copy link
Contributor Author

PJ789 commented Dec 26, 2021

@edgar-bonet - this is the same code you reviewed previously, with the change to fix the backslash scan code. Apologies for any confusion.

@github-actions
Copy link

Memory usage change @ 124a0cb

Board flash % RAM for global variables %
arduino:avr:leonardo 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:sam:arduino_due_x_dbg 0 - 0 0.0 - 0.0 N/A N/A
arduino:samd:mkrzero 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Serial
flash		 % examples/Serial
RAM for global variables		 %
arduino:avr:leonardo 0 0.0 0 0.0
arduino:sam:arduino_due_x_dbg 0 0.0 N/A N/A
arduino:samd:mkrzero 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Serial<br>flash,%,examples/Serial<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0
arduino:sam:arduino_due_x_dbg,0,0.0,N/A,N/A
arduino:samd:mkrzero,0,0.0,0,0.0

@per1234 per1234 added the type: enhancement Proposed improvement label Dec 26, 2021
edgar-bonet
edgar-bonet approved these changes Dec 26, 2021
View reviewed changes
Copy link
Collaborator

@edgar-bonet edgar-bonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a typo in my name in the commit log, it all looks good to me.

edgar-bonet
edgar-bonet reviewed Jan 6, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

Memory usage change @ 0904fb1

Board flash % RAM for global variables %
arduino:avr:leonardo 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:sam:arduino_due_x_dbg 0 - 0 0.0 - 0.0 N/A N/A
arduino:samd:mkrzero 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Serial
flash		 % examples/Serial
RAM for global variables		 %
arduino:avr:leonardo 0 0.0 0 0.0
arduino:sam:arduino_due_x_dbg 0 0.0 N/A N/A
arduino:samd:mkrzero 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Serial<br>flash,%,examples/Serial<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0
arduino:sam:arduino_due_x_dbg,0,0.0,N/A,N/A
arduino:samd:mkrzero,0,0.0,0,0.0

@facchinm facchinm merged commit b793c5c into arduino-libraries:master Jan 10, 2022
@facchinm
Copy link
Contributor

Squashed and merged, thanks!

@edgar-bonet edgar-bonet mentioned this pull request Apr 2, 2022
Merged
@edgar-bonet edgar-bonet mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgar-bonet edgar-bonet edgar-bonet approved these changes

Assignees
No one assigned
Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PJ789 @facchinm @edgar-bonet @per1234