Skip to content

[AE-158] Specify compatible sketches for each fqbn: #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

aliphys
Copy link
Contributor

@aliphys aliphys commented Sep 5, 2023

Due to differences in architecture and physical implementation (e.g. no SD slot on the Opta) not all examples in this library are supposed to work with all architectures. In this PR, we use the following scheme to define for which fqbn: which examples should be checked.

include:
  - board:
    additional-sketch-path: |
      - example/SketchA
      - example/SketchB

We define a UNIVERSAL_SKETCH_PATH that includes the location of the test sketches in extras/tests. These tests should work for all platforms. matrix.additional-sketch-paths references the sketches for each fqbn.

@aliphys aliphys added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Sep 5, 2023
@aliphys aliphys self-assigned this Sep 5, 2023
@aliphys
Copy link
Contributor Author

aliphys commented Sep 5, 2023

Test sketches in extras/tests compile status as of 7c3dd72 :

  • arduino:mbed_portenta:envie_m7
  • arduino:renesas_portenta:portenta_c33-> Error: Process completed with exit code 1. ->Log
  • arduino:mbed_opta:opta -> Error: Process completed with exit code 1.-> Log

@aliphys
Copy link
Contributor Author

aliphys commented Sep 5, 2023

Merging #9 should fix compilation issues on C33 and Opta.

@cristidragomir97 cristidragomir97 marked this pull request as ready for review September 6, 2023 15:13
@cristidragomir97 cristidragomir97 merged commit 5c42821 into main Sep 6, 2023
@cristidragomir97 cristidragomir97 deleted the aliphys/SelectiveCompileWorkflow branch September 6, 2023 15:13
@sebromero sebromero restored the aliphys/SelectiveCompileWorkflow branch September 6, 2023 20:04
@sebromero sebromero deleted the aliphys/SelectiveCompileWorkflow branch September 6, 2023 20:09
@aliphys
Copy link
Contributor Author

aliphys commented Sep 6, 2023

Merging #9 should fix compilation issues on C33 and Opta.

If the compilation issue were fixed, which commit was it? The #9 PR mentioned is still open. I wanted to make sure the compile-sketches workflow is compatible with the changes prior to merging :)

@aliphys
Copy link
Contributor Author

aliphys commented Sep 7, 2023

@per1234 's changes merged into the main branch as part of #16. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants