-
Notifications
You must be signed in to change notification settings - Fork 11
Fix within/writable spelling in .\src\USBHost
and .\src\USBHost3GModule
#36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -81,7 +81,7 @@ class WANDongleSerialPort : public IUSBHostSerial { | |||
* | |||
* @returns the number of bytes available | |||
*/ | |||
virtual int writeable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cristidragomir97, Just wanted to point out that I changed the writeable()
methods to writable()
across the entire repository. This change shouldn't create any problems, should it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the implications of this on other libraries/examples. Let's ask @facchinm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Memory usage change @ 7a18865
Click for full report table
Click for full report CSV
|
We should bump the version number in the next release, since the function rename could potentially be a breaking change. |
@@ -81,7 +81,7 @@ class WANDongleSerialPort : public IUSBHostSerial { | |||
* | |||
* @returns the number of bytes available | |||
*/ | |||
virtual int writeable(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
The current status on the Readme page states that the Spelling Check is not passing.
This PR resolves issues in https://github.com/arduino-libraries/Arduino_USBHostMbed5/actions/runs/6708967539 to make sure that the spell check passes https://github.com/arduino-libraries/Arduino_USBHostMbed5/actions/runs/6723001780