New combined demo showing most non I2C input sensors.

[marcmerlin]

It'd be great to query I2C too, but those sensors unfortunately
are not setup to use a different I2C address and conflict with
one another unless you put some solder bridges to change the address

[marqdevx]

Are you using the version 1.0.5?
If you are not, please update the library :) and try if you can use both at the same time, thanks!

[marcmerlin]

@marqdevx enabling any of those 2 lines with library 1.0.5, stops the OLED from working.

[marcmerlin]

correct, I have 1.0.5. See line 75/76 in https://github.com/arduino-libraries/Arduino_SensorKit/pull/6/files
I did run the I2C scanner, and indeed all 3 devices have different addresses

[marcmerlin]

Without looking in details, is it an issue that your base library does not give I2C addresses for the sensors, and they get auto detected if you use one at a time, but if you use 2 or 3 of them the autodetection fails. However if you were to hardcode the addresses, then they would work at the same time?

[marqdevx]

The sensors and the display have a default address, as far as I know only the display's address can be changed.
What do you mean by autodetection fails?

I can use them at the same time

[marcmerlin]

@marqdevx : since the hardware addresses do not conflict (I was afraid they did, but I2C scan shows they don't), that part is not an issue.
The sensors work if I use them separately, but they do not work if I use OLED + another one.

If you have a demo that uses all 3 sensors at the same time, please add it to this repo.
In the meantime, you can also look at this PR and/or download https://github.com/marcmerlin/Arduino_SensorKit/blob/Combined_Demo/examples/Combined_Demo/Combined_Demo.ino
For me, the moment I uncomment one of those, the OLED stops working:

  //Accelerometer.begin();
  //Pressure.begin();

I may be doing something wrong, in which case having a known good example, would be even more valuable.

[marcmerlin]

Any update on this? I'd be happy to write a better combined demo for you, but I'd rather avoid wasting time debugging I2C issues if you already know what's going on

[marcmerlin]

i just added support for the buzzer and fixed cursor values for u8x8

[marcmerlin]

And now it shows Hz value on screen and outputs that on the buzzer when pushed.

[marcmerlin]

Thanks to #13 I can get all sensors working now.
Would you be ok merging this pull request?

[marcmerlin]

[marqdevx]

@marcmerlin Could you have a look at the changes I made?

Basically I've just made it more easy to understand, cause the SensorKit its made for not that advanced users, it's nice if a non experience user can understand the flow of the program easily.

For example removing the uint8_t can cause doubts.

And thanks for the sketch, its working fine, and its super cool, good job :)

Have a nice one!

[marcmerlin]

@marqdevx thanks for the code review and modifications.
you're better at making code for beginners than I am, everything you did makes sense.
The only thing is that I have a pet peeve against using int which is ultimately an unknown size (which arguably could be 8bits when you need 16, and often wastes 32bits when you only need 16 or 8), but I'll leave that one up to you.

I assume you tested the code after your modifications (I don't have my board next to me right now), and if so, seems fine to submit, thank you.

[marqdevx]

Thanks, yes I get the point of the size, but at this level its not "important", its better to focus to cover a bigger range of user's knowledge.

Yes, I did and it works.

I will merge it and release a new version.

Thanks! Have a nice one 👍

[marcmerlin]

Great, thanks for your help and getting I2C to work for all the sensors at the same time.