Skip to content

Breakout PDM #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2021
Merged

Breakout PDM #12

merged 3 commits into from
May 25, 2021

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Apr 20, 2021

needs arduino/ArduinoCore-mbed#199

merge after #9

@pennam pennam force-pushed the breakout_pdm branch 3 times, most recently from 5d47e1e to 002ebee Compare April 23, 2021 07:18
@pennam pennam mentioned this pull request Apr 26, 2021
@pennam pennam requested a review from aentinger May 20, 2021 10:28
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, I've mentioned a couple of minor points though which I'd ask you to consider.

Avoid race-condition on samplesRead
@pennam pennam requested a review from aentinger May 25, 2021 09:32
@facchinm facchinm merged commit ada6bf7 into arduino-libraries:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants