Clean-up of connection handler for better maintainability. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aentinger
force-pushed
the
conhdl-clean-up
branch
from
a33784d to
5f9a3b5
Compare
…llback' as deprecated since the function 'addCallback' is covering the functionality of all three functions
…rivate and access them via one generalised execCallback function
aentinger
force-pushed
the
conhdl-clean-up
branch
from
5f9a3b5 to
fc61661
Compare
… interval based on the current network connection state
…el all over the code
…tionality is covered by update_handleInit
…hods actually overwrite another virtual method from the base class
…orms the state change
…updateDisconnecting()
…pdateDisconnected()
…s function is overwritten
…e::INIT since this is already done in the base class
…s function is overwritten
…ace depends on an uninitialized variable
…ow to share the code for the function across all connection handlers
…this is really the only type of board which needs this state
… between all connection handlers
…hine in the base class - all derived classes import their actual behaviour within their template methods
…ess it (which they should not need anyway)
… not register callbacks
aentinger
force-pushed
the
conhdl-clean-up
branch
2 times, most recently
from
0b01bbf to
7656d52
Compare
aentinger
force-pushed
the
conhdl-clean-up
branch
from
7656d52 to
28fb13e
Compare
|
Successfully tested on PROD with
@AlbyIanna can you please test with |
AlbyIanna
approved these changes
Mar 16, 2020
|
@Rocketct waiting for your tests |
|
From Italy, with our test SIM the connection fall when the module try to open a socket to the broker,but this is expected due to the SIM's plan. Today i plan another test in other country and i'll let you know the results as soon as i get it |
|
test3ed form our team in Malmo and works properly, the getting started and the cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.