Rework 01_Braccio_learning_mode example #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Memory usage change @ 50733fe
Click for full report table
Click for full report CSV |
aentinger
suggested changes
Apr 26, 2022
There was a problem hiding this comment.
I've tested Braccio_Learn_and_Repeat.ino and liked the workflow very much (considerably more intuitive than before). However, there's the possibility of an array overflow (present since ancient times, not just this PR) which needs to be addressed.
The differences between Braccio_Learn_and_Repeat.ino and 01_Braccio_learning_mode.inoare so minimal that I wonder why we need both? If both are to be kept than I suggest to make them at least code-identical, i.e. copy the former into the latter.
See similarity/differences via meld
meld examples/Braccio_Learn_and_Repeat/Braccio_Learn_and_Repeat.ino examples/Platform_Tutorials/projects/p03-learning-mode/01_Braccio_learning_mode/01_Braccio_learning_mode.ino 
per1234
requested changes
Apr 26, 2022
...m_Tutorials/projects/p03-learning-mode/01_Braccio_learning_mode/01_Braccio_learning_mode.ino
Outdated
Show resolved
Hide resolved
…le after learning
…selected. "STOP" button actually does what it's supposed to do
aentinger
force-pushed
the
rework_examples
branch
from
50733fe to
8ce8384
Compare
…orm_Tutorials/projects/p03-learning-mode/01_Braccio_learning_mode are identical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few enhancements on the
01_Braccio_learning_modeexample. See commits for further details