Skip to content

Hotfixes newcore #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Hotfixes newcore #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c05e72d
Initial_Servo_Position: increase timout to 5 seconds
facchinm Feb 15, 2022
452f497
Wait 200ms before actually starting the display thread
facchinm Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Tools/Factory_Set_Initial_Servo_Position/Factory_Set_Initial_Servo_Position.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ static std::array<InitialServoPosition, 6> const INITIAL_SERVO_POSITION =

bool set_initial_servo_position(int const id, float const target_angle)
{
auto isTimeout = [](unsigned long const start) -> bool { return ((millis() - start) > 2000); };
auto isTimeout = [](unsigned long const start) -> bool { return ((millis() - start) > 5000); };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't harm any operation, you just have to wait longer in case something does indeed time out 🤷 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Come to think of it, you are miss reading the code. The timeout function is only applied for 2 individual steps. This means that the timeout is not for the whole function but only for those two steps. Consequently the delay(500); is not negatively effecting the timeout.

Can we please go back to assessing a root cause before throwing around random "hot fixes"?


auto start = millis();

Expand Down
1 change: 1 addition & 0 deletions src/Braccio++.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ void BraccioClass::lvgl_init()

void BraccioClass::display_thread_func()
{
delay(200);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which underlying ressources would not be ready? What would be lv_fs_read be needed for? To my knowledge the LVGL filesystem is not used, the GIF for the splash screen is a binary array stored in flash. What's the callstack when lv_fs_read fails?

for(;;)
{
lv_task_handler();
Expand Down