Fix: Only ping within the motor connection thread. by aentinger · Pull Request #29 · arduino-libraries/Arduino_Braccio_plusplus

Turn BraccioClass::connected into an inline function call.

aentinger

committed

Move MotorsWrapper to end of include file, allows using Braccio.connected - otherwise redundant calls to 'ping'.

aentinger

committed

Replace direct access to member variable 'ping_allowed' with pingOn()/pingOff() API.

aentinger

committed

Set all motor status LEDs to 'red' immediately during initialisation.

aentinger

committed

Grouping variables and functions related to motor connection code together within code.

aentinger

committed

In related news group display thread with display member variables.

aentinger

committed

Fix direct access to member variable 'ping_allowed'.

aentinger

committed

Ensure that there are no race conditions, since '_connected' is updated within a separate thread and '_ping_allowed' is set from another thread than the motor connection thread check.

aentinger

committed

CamelCase for consistency.

aentinger

committed

Prefixing boolean member with '_is' which makes it easier to read.

aentinger

committed

Prefixing boolean member with '_is' which makes it easier to read.

aentinger

committed

Use only the maximum number of array elements necessary.

aentinger

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Only ping within the motor connection thread.#29

Commits on Jan 19, 2022

Turn BraccioClass::connected into an inline function call.

Move MotorsWrapper to end of include file, allows using Braccio.connected - otherwise redundant calls to 'ping'.

Replace direct access to member variable 'ping_allowed' with pingOn()/pingOff() API.

Set all motor status LEDs to 'red' immediately during initialisation.

Grouping variables and functions related to motor connection code together within code.

In related news group display thread with display member variables.

Fix direct access to member variable 'ping_allowed'.

Ensure that there are no race conditions, since '_connected' is updated within a separate thread and '_ping_allowed' is set from another thread than the motor connection thread check.

CamelCase for consistency.

Prefixing boolean member with '_is' which makes it easier to read.

Prefixing boolean member with '_is' which makes it easier to read.

Use only the maximum number of array elements necessary.