Skip to content

Added configuration parameter to select the sensor present #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Added configuration parameter to select the sensor present #47

merged 1 commit into from
Nov 4, 2024

Conversation

maidnl
Copy link
Contributor

@maidnl maidnl commented Nov 4, 2024

Added configuration parameter on begin to select the sensor mounted on the board:

  • Only Accelerometer
  • Only Magnetometer
  • Both present

Default value -> Both present

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Memory usage change @ b65a10b

Board flash % RAM for global variables %
arduino:mbed_edge:edge_control 🔺 +64 - +64 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 🔺 +64 - +64 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +104 - +104 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A
arduino:samd:mkr1000 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 🔺 +100 - +100 +0.04 - +0.04 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +128 - +128 +0.01 - +0.01 0 - 0 0.0 - 0.0
rp2040:rp2040:rpipico 🔺 +96 - +96 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SimpleAccelerometer
flash		 % examples/SimpleAccelerometer
RAM for global variables		 % examples/SimpleGyroscope
flash		 % examples/SimpleGyroscope
RAM for global variables		 % examples/SimpleMagnetometer
flash		 % examples/SimpleMagnetometer
RAM for global variables		 %
arduino:mbed_edge:edge_control 64 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0
arduino:mbed_nano:nano33ble 64 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0
arduino:mbed_nano:nanorp2040connect 104 0.0 0 0.0 104 0.0 0 0.0 104 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:samd:mkr1000 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrfox1200 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrgsm1400 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrnb1500 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrvidor4000 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrwan1300 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrwan1310 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrwifi1010 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
arduino:samd:mkrzero 100 0.04 0 0.0 100 0.04 0 0.0 100 0.04 0 0.0
esp32:esp32:esp32 128 0.01 0 0.0 128 0.01 0 0.0 128 0.01 0 0.0
rp2040:rp2040:rpipico 96 0.0 0 0.0 96 0.0 0 0.0 96 0.0 0 0.0
Click for full report CSV 
Board,examples/SimpleAccelerometer<br>flash,%,examples/SimpleAccelerometer<br>RAM for global variables,%,examples/SimpleGyroscope<br>flash,%,examples/SimpleGyroscope<br>RAM for global variables,%,examples/SimpleMagnetometer<br>flash,%,examples/SimpleMagnetometer<br>RAM for global variables,%
arduino:mbed_edge:edge_control,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0
arduino:mbed_nano:nano33ble,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0
arduino:mbed_nano:nanorp2040connect,104,0.0,0,0.0,104,0.0,0,0.0,104,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7:target_core=cm4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrfox1200,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrgsm1400,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrnb1500,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrvidor4000,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrwan1300,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrwan1310,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrwifi1010,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
arduino:samd:mkrzero,100,0.04,0,0.0,100,0.04,0,0.0,100,0.04,0,0.0
esp32:esp32:esp32,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0
rp2040:rp2040:rpipico,96,0.0,0,0.0,96,0.0,0,0.0,96,0.0,0,0.0

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Nov 4, 2024
@facchinm facchinm mentioned this pull request Nov 4, 2024
Merged
@facchinm
Copy link
Collaborator

facchinm commented Nov 4, 2024

I would minimize the changes by only taking into account the if (!BOSCH_*_ONLY) when excluding an initialization (to get rid of all the code duplication)

facchinm
facchinm requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of the code duplication by using a if !BOSCH_*_ONLY pattern

@maidnl maidnl closed this Nov 4, 2024
@maidnl maidnl force-pushed the add_sensor_configuration branch from b65a10b to d4e5ee3 Compare November 4, 2024 14:18
@maidnl maidnl reopened this Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Memory usage change @ a749179

Board flash % RAM for global variables %
arduino:mbed_edge:edge_control 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 +4 - +4 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A
arduino:samd:mkr1000 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 🔺 +8 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
esp32:esp32:esp32 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
rp2040:rp2040:rpipico 🔺 +16 - +16 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SimpleAccelerometer
flash		 % examples/SimpleAccelerometer
RAM for global variables		 % examples/SimpleGyroscope
flash		 % examples/SimpleGyroscope
RAM for global variables		 % examples/SimpleMagnetometer
flash		 % examples/SimpleMagnetometer
RAM for global variables		 %
arduino:mbed_edge:edge_control 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 4 0.0 0 0.0 4 0.0 0 0.0 4 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:samd:mkr1000 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrfox1200 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrgsm1400 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrnb1500 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrvidor4000 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrwan1300 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrwan1310 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrwifi1010 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
arduino:samd:mkrzero 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
esp32:esp32:esp32 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
rp2040:rp2040:rpipico 16 0.0 0 0.0 16 0.0 0 0.0 16 0.0 0 0.0
Click for full report CSV 
Board,examples/SimpleAccelerometer<br>flash,%,examples/SimpleAccelerometer<br>RAM for global variables,%,examples/SimpleGyroscope<br>flash,%,examples/SimpleGyroscope<br>RAM for global variables,%,examples/SimpleMagnetometer<br>flash,%,examples/SimpleMagnetometer<br>RAM for global variables,%
arduino:mbed_edge:edge_control,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,4,0.0,0,0.0,4,0.0,0,0.0,4,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7:target_core=cm4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:samd:mkr1000,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrfox1200,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrgsm1400,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrnb1500,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrvidor4000,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrwan1300,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrwan1310,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrwifi1010,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
arduino:samd:mkrzero,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0
esp32:esp32:esp32,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
rp2040:rp2040:rpipico,16,0.0,0,0.0,16,0.0,0,0.0,16,0.0,0,0.0

@facchinm facchinm merged commit 551c099 into arduino-libraries:master Nov 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maidnl @facchinm @per1234