Skip to content

Provide error message when trying to compile this library for the M4 core. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Provide error message when trying to compile this library for the M4 core. #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Arduino_AdvancedAnalog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@
* INCLUDE
**************************************************************************************/

#ifdef ARDUINO_PORTENTA_H7_M4
# error "This library on works on the M7 core of any STM32H747 based board (Portenta H7, Giga, X8)."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X8 target runs on M4, are we sure it works there too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake in my thinking. I thought it doesn't work there, but then had a logic toogle in my brain. Will fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, not actually a mistake, but a bit redundant, since you can't target the M7 on the H747 of the X8.

#endif

#include "AdvancedADC.h"
#include "AdvancedDAC.h"

Expand Down