Skip to content

Add support for RS485 on Controllino Maxi/Mega #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

vzahradnik
Copy link

Support for RS485 on Controllino Maxi/Mega

  • This PR adds support for RS485 integrated into Controllino Maxi/Mega boards.
  • These boards use different PINs and different Serial object. Otherwise, the logic works the same.
  • I added a simple #ifdef...endif clause to check for these boards.
  • If users include the CONTROLLINO library, these flags are set for them. Including their library is recommended by their official guides. As an alternative, users can just set the flag #define CONTROLLINO_MAXI or #define CONTROLLINO_MEGA in their sketch. In such a case, I added a clause inside src/RS485.h, which tries to load the CONTROLLINO library.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ vzahradnik
❌ Robert-Faltus
You have signed the CLA already but the status is still pending? Let us recheck it.

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 14, 2023
@pmmarquez
Copy link
Contributor

We at Controllino are now updating our board support packages and we pretend to ad support for ArduinoRS485 by defining RS485_SERIAL_PORT, RS485_DEFAULT_TX_PIN, RS485_DEFAULT_RE_PIN, RS485_DEFAULT_DE_PIN we just need the small change on #46, anyway thanks to @vzahradnik for this effort 👍

@aentinger
Copy link
Contributor

I am closing this PR, since the intended functionality has been achieved via merging #51 .

@aentinger aentinger closed this Feb 28, 2024
@per1234 per1234 added the conclusion: duplicate Has already been submitted label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants