Skip to content

Add esp32 OTA support #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 19, 2023
Merged

Add esp32 OTA support #350

merged 6 commits into from
Jan 19, 2023

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented Jan 18, 2023 •
edited
Loading

@codecov-commenter
Copy link

Codecov Report

Merging #350 (c25d61e) into master (5776c7f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files          27       27           
  Lines        1130     1130           
=======================================
  Hits         1072     1072           
  Misses         58       58

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jan 18, 2023
@pennam pennam marked this pull request as ready for review January 18, 2023 13:43
@pennam pennam requested review from mirkokurt and aentinger January 18, 2023 13:44
@pennam
Copy link
Collaborator Author

pennam commented Jan 18, 2023

Magic number fixed Thanks @mirkokurt 🚀

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jan 18, 2023
@pennam
Copy link
Collaborator Author

pennam commented Jan 18, 2023

CI fixed for mkr100 mkrwan and mkrnb. esp32 still fails becauseArduino_ESP32_OTA is not yet published.

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jan 18, 2023
mirkokurt
mirkokurt approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@mirkokurt mirkokurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done!

aentinger
aentinger reviewed Jan 19, 2023
View reviewed changes
aentinger
aentinger reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, love the refactoring in different source files for different architectures, much cleaner.

@aentinger
Copy link
Contributor

aentinger commented Jan 19, 2023 •
edited
Loading

CI fixed for mkr100 mkrwan and mkrnb. esp32 still fails becauseArduino_ESP32_OTA is not yet published.

You could make this one public: https://github.com/bcmi-labs/Arduino_ESP32_OTA and then specify the link for the CI action to work, i.e.

- name: Arduino_ESP32_OTA
+ - source-url: https://github.com/bcmi-labs/Arduino_ESP32_OTA

Of course you still need to update this once the library is published 🤷

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jan 19, 2023
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jan 19, 2023
@github-actions
Copy link

Memory usage change @ e824e4c

Board flash % RAM for global variables %
arduino:mbed_nano:nanorp2040connect 🔺 0 - +12 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +222100 - +222192 +16.94 - +16.95 🔺 +11148 - +11148 +3.4 - +3.4
esp8266:esp8266:huzzah 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash		 % examples/ArduinoIoTCloud-Advanced
RAM for global variables		 % examples/ArduinoIoTCloud-Basic
flash		 % examples/ArduinoIoTCloud-Basic
RAM for global variables		 % examples/utility/ArduinoIoTCloud_Travis_CI
flash		 % examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables		 % examples/utility/Provisioning
flash		 % examples/utility/Provisioning
RAM for global variables		 % examples/utility/SelfProvisioning
flash		 % examples/utility/SelfProvisioning
RAM for global variables		 %
arduino:mbed_nano:nanorp2040connect 12 0.0 0 0.0 12 0.0 0 0.0 12 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 16 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 8 0.0 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 8 0.0 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 222152 16.95 11148 3.4 222100 16.94 11148 3.4 222192 16.95 11148 3.4
esp8266:esp8266:huzzah 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed_nano:nanorp2040connect,12,0.0,0,0.0,12,0.0,0,0.0,12,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,16,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,8,0.0,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,8,0.0,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,222152,16.95,11148,3.4,222100,16.94,11148,3.4,222192,16.95,11148,3.4,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jan 19, 2023
@pennam pennam merged commit 34be317 into arduino-libraries:master Jan 19, 2023
@pennam pennam deleted the add-esp32-ota branch May 17, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger left review comments

@mirkokurt mirkokurt mirkokurt approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pennam @codecov-commenter @aentinger @mirkokurt @per1234