SecKey length

[bkniffler]

Hey, currently the SecKey length is fixed to 21 chars (https://github.com/arduino-libraries/ArduinoHttpClient/blob/master/src/WebSocketClient.cpp#L39), but I've seen some examples (f.e. wikipedia article) using 24 chars. There doesn't seem to be a specification about the length, but I've stumbled upon libraries that expect the length of 24 chars (https://www.npmjs.com/package/uws).

So, I'd suggest to make the SecKey length overwritable and maybe change the default length to 24 characters.

[bkniffler]

https://github.com/uWebSockets/bindings/issues/15#event-1060116778

[sandeepmistry]

@bkniffler

So, I'd suggest to make the SecKey length overwritable and maybe change the default length to 24 characters.

I'm ok with changing the default length to 24 characters, could you please submit a pull request for this?

At this point, I don't think we need an option to make it configurable ...

[bkniffler]

Sorry, I don't currently have the time/urgence to do it since we're reconsidering using arduino for our use-case. I will still leave this open in case someone else wants to tackle this!

[sandeepmistry]

PR #26 submitted for this.

[sandeepmistry]

Closed via #26.