Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

fix_boolean_management #49

Merged
merged 2 commits into from
Dec 16, 2019
Merged

fix_boolean_management #49

merged 2 commits into from
Dec 16, 2019

Conversation

ilcato
Copy link
Contributor

@ilcato ilcato commented Dec 11, 2019

Manage the case to have boolean values received as integers 0/1 in the CBOR message.

Manage the case to have boolean values received as integers 0/1 in the CBOR message.
@TravisBuddy
Copy link

Travis tests have failed

Hey @ilcato,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make
$ make
Scanning dependencies of target testArduinoCloudThing
[  3%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/Arduino.cpp.o
[  7%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/main.cpp.o
[ 11%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_addPropertyReal.cpp.o
[ 14%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_callback.cpp.o
[ 18%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_CloudColor.cpp.o
[ 22%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_CloudLocation.cpp.o
[ 25%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_decode.cpp.o
[ 29%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_encode.cpp.o
[ 33%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_publishEvery.cpp.o
[ 37%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_publishOnChange.cpp.o
[ 40%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_publishOnChangeRateLimit.cpp.o
[ 44%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_readOnly.cpp.o
[ 48%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/test_writeOnly.cpp.o
[ 51%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/src/TestUtil.cpp.o
[ 55%] Building CXX object CMakeFiles/testArduinoCloudThing.dir/home/travis/build/arduino-libraries/ArduinoCloudThing/src/ArduinoCloudThing.cpp.o
oudThing/src/ArduinoCloudProperty.cpp.o' failed
make[2]: *** [CMakeFiles/testArduinoCloudThing.dir/home/travis/build/arduino-libraries/ArduinoCloudThing/src/ArduinoCloudProperty.cpp.o] Error 1
CMakeFiles/Makefile2:72: recipe for target 'CMakeFiles/testArduinoCloudThing.dir/all' failed
make[1]: *** [CMakeFiles/testArduinoCloudThing.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
TravisBuddy Request Identifier: 59adce20-1bfd-11ea-ba59-e12deadb3a4c

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #49 into master will decrease coverage by 0.58%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   96.19%   95.61%   -0.59%     
==========================================
  Files          24       24              
  Lines         815      821       +6     
==========================================
+ Hits          784      785       +1     
- Misses         31       36       +5
Impacted Files Coverage Δ
src/ArduinoCloudProperty.cpp 93.49% <28.57%> (-3.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6886c7a...31e9e68. Read the comment docs.

@ilcato ilcato marked this pull request as ready for review December 12, 2019 09:34
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger aentinger merged commit cf7d489 into master Dec 16, 2019
@aentinger aentinger deleted the fix_boolean_management branch December 16, 2019 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants