Skip to content

fix the potential overflow problem of leAdvertisingReport->eirData #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix the potential overflow problem of leAdvertisingReport->eirData #220

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7cfcdd
fix potential arrary overflow problem of _recvBuffer
bigbearishappy Dec 17, 2021
ecfe56a
Update src/utility/HCI.cpp
bigbearishappy Dec 21, 2021
4f4bdd3
optimize code of potential overflow _recvBuffer
bigbearishappy Dec 21, 2021
89ab479
add the debug msg when the _recvBuffer overflow
bigbearishappy Dec 22, 2021
71ed75d
fix the potential overflow problem of leAdvertisingReport->eirData
bigbearishappy Jan 20, 2022
dcd4105
Merge branch 'master' of https://github.com/bigbearishappy/ArduinoBLE
bigbearishappy Jan 20, 2022
7c4b6b6
Merge branch 'arduino-libraries:master' into master
bigbearishappy Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/utility/HCI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,10 @@ void HCIClass::handleEventPkt(uint8_t /*plen*/, uint8_t pdata[])
uint8_t eirData[31];
} *leAdvertisingReport = (EvtLeAdvertisingReport*)&pdata[sizeof(HCIEventHdr) + sizeof(LeMetaEventHeader)];

if(leAdvertisingReport->eirLength > sizeof(leAdvertisingReport->eirData)){
return ;
}

if (leAdvertisingReport->status == 0x01) {
// last byte is RSSI
int8_t rssi = leAdvertisingReport->eirData[leAdvertisingReport->eirLength];
Expand Down