Skip to content

Incorrect change applied for ARDUINO_GIGA #292

Closed
@paulvha

Description

@paulvha

In order to support ARDUINO_GIGA a number of changes had been applied to create version 1.3.3m, documented on f852716.

There is an error in those changes, copy/paste is applied to quickly, which results in incorrect behavior.

In the file HCICordioTransport.cpp, line 238, A change was made that results in the OPPOSITE of want is needed. As a result getDriver().terminate() is NOW called for the PORTENTA and NICLA_VISION and ARDUINO_GIGA, where it should NOT.

-#if !defined(ARDUINO_PORTENTA_H7_M4) && !defined(ARDUINO_PORTENTA_H7_M7) && !defined(ARDUINO_NICLA_VISION)
+#if defined(ARDUINO_PORTENTA_H7_M4) || defined(ARDUINO_PORTENTA_H7_M7) || defined(ARDUINO_NICLA_VISION) || defined(ARDUINO_GIGA)
  CordioHCIHook::getDriver().terminate();
#endif

The change should be :

#if !defined(ARDUINO_PORTENTA_H7_M4) && !defined(ARDUINO_PORTENTA_H7_M7) && !defined(ARDUINO_NICLA_VISION) && !defined(ARDUINO_GIGA)
  CordioHCIHook::getDriver().terminate();
#endif

regards,
Paulvha

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions