Skip to content

Honor read and write params to begin_transaction #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Honor read and write params to begin_transaction #84

merged 1 commit into from
Oct 13, 2018

Conversation

gmacon
Copy link
Contributor

@gmacon gmacon commented Oct 11, 2018

In my application, I saw an error where a transaction containing only AQL would fail because the write collections were not declared. I traced this to the read and write parameters to begin_transaction not being passed all the way through to the database in commit.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.893% when pulling 0bffcff on gmacon:transaction-aql into 51b0060 on joowani:master.

@coveralls
Copy link

coveralls commented Oct 11, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 63813bd on gmacon:transaction-aql into 51b0060 on joowani:master.

@joowani joowani changed the base branch from master to dev October 13, 2018 00:05
@joowani
Copy link
Contributor

joowani commented Oct 13, 2018

Thank you for the PR @gmacon!

@joowani joowani merged commit 37dd0ab into arangodb:dev Oct 13, 2018
@gmacon gmacon deleted the transaction-aql branch October 13, 2018 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants