Skip to content

Pull request to address one connection per send on DefaultClient #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2015
Merged

Pull request to address one connection per send on DefaultClient #3

merged 2 commits into from
Jun 10, 2015

Conversation

avinash240
Copy link
Contributor

The session based client is faster than the default one, especially at high rates. It's no longer paying the connection and breakdown penalty per socket and instead is connection pooling, which is great since the current DefaultArangoAgent was creating a new connection per document sent.
There are two tests, the geo tests. They don't return back the unique flag that you send in, I suspect that that index type does not support unique. However, I'm new to arangodb, so I don't know perhaps it's a bug in the server I'm running 2.5.5. I also added the sparse and selectivity keys where needed. I'm not sure if this breaks backwards compat with older servers, I'm sorry if it does, I just didn't want to hand back a broken test suite especially since you went through the trouble to build one.

…ons on, added close method to sessionbased client, and added session_based boolean method to base class so code can be written to call close if necessary for cleanup
joowani pushed a commit that referenced this pull request Jun 10, 2015
Pull request to address one connection per send on DefaultClient
@joowani joowani merged commit 2f86b0f into arangodb:development Jun 10, 2015
@joowani
Copy link
Contributor

joowani commented Jun 14, 2015

Hello Marlon,

I've updated py-arango driver to support version 2.5.

Thanks!

Sincerely,
Joohwan

On Tue, Jun 9, 2015 at 8:25 AM, Marlon Bailey notifications@github.com
wrote:

The session based client is faster than the default one, especially at
high rates. It's no longer paying the connection and breakdown penalty per
socket and instead is connection pooling, which is great since the current
DefaultArangoAgent was creating a new connection per document sent.
There are two tests, the geo tests. They don't return back the unique flag
that you send in, I suspect that that index type does not support unique.
However, I'm new to arangodb, so I don't know perhaps it's a bug in the
server I'm running 2.5.5. I also added the sparse and selectivity keys
where needed. I'm not sure if this breaks backwards compat with older
servers, I'm sorry if it does, I just didn't want to hand back a broken

test suite especially since you went through the trouble to build one.

You can view, comment on, or merge this pull request online at:

#3
Commit Summary

  • changed name to keep similar naming convention
  • fixed the tests I can, skipped the ones I don't want to make
    assumptions on, added close method to sessionbased client, and added
    session_based boolean method to base class so code can be written to call
    close if necessary for cleanup

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants